Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_follow_redirect #975

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Update test_follow_redirect #975

merged 1 commit into from
Apr 21, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 21, 2022

Closes #966.

@jwodder jwodder added the tests Add or improve existing tests label Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #975 (0ba5920) into master (00ee4dd) will decrease coverage by 24.49%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           master     #975       +/-   ##
===========================================
- Coverage   87.56%   63.06%   -24.50%     
===========================================
  Files          65       65               
  Lines        8104     8019       -85     
===========================================
- Hits         7096     5057     -2039     
- Misses       1008     2962     +1954     
Flag Coverage Δ
unittests 63.06% <33.33%> (-24.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_dandiarchive.py 88.88% <33.33%> (-11.12%) ⬇️
dandi/validate.py 0.00% <0.00%> (-100.00%) ⬇️
dandi/bids_validator_xs.py 0.00% <0.00%> (-93.53%) ⬇️
dandi/tests/test_bids_validator_xs.py 9.09% <0.00%> (-90.91%) ⬇️
dandi/support/tests/test_digests.py 16.66% <0.00%> (-83.34%) ⬇️
dandi/support/tests/test_iterators.py 13.15% <0.00%> (-81.58%) ⬇️
dandi/cli/tests/test_ls.py 21.05% <0.00%> (-78.95%) ⬇️
dandi/tests/test_validate.py 22.22% <0.00%> (-77.78%) ⬇️
dandi/tests/test_pynwb_utils.py 20.00% <0.00%> (-77.78%) ⬇️
dandi/cli/tests/test_formatter.py 22.22% <0.00%> (-77.78%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ee4dd...0ba5920. Read the comment docs.

== "https://gui.dandiarchive.org/#/file-browser/folder/5e72b6ac3da50caa9adb0498"
)
url = follow_redirect("https://bit.ly/dandi12")
assert re.match(r"https://(.*\.)?dandiarchive.org", url)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample invocation passed

2022-04-21T14:06:35.9732127Z dandi/tests/test_dandiarchive.py::test_follow_redirect PASSED

so I guess coverage was not submitted due to other errors orwhatnot

@yarikoptic yarikoptic merged commit 1a09bea into master Apr 21, 2022
@yarikoptic yarikoptic deleted the gh-966 branch April 21, 2022 14:19
@github-actions
Copy link

🚀 PR was released in 0.39.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_follow_redirect no longer works
2 participants