Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip trailing slash from URLs in /server-info #972

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 21, 2022

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #972 (20ecaac) into master (00ee4dd) will decrease coverage by 24.48%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #972       +/-   ##
===========================================
- Coverage   87.56%   63.07%   -24.49%     
===========================================
  Files          65       65               
  Lines        8104     8020       -84     
===========================================
- Hits         7096     5059     -2037     
- Misses       1008     2961     +1953     
Flag Coverage Δ
unittests 63.07% <100.00%> (-24.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/utils.py 68.55% <100.00%> (-12.72%) ⬇️
dandi/validate.py 0.00% <0.00%> (-100.00%) ⬇️
dandi/bids_validator_xs.py 0.00% <0.00%> (-93.53%) ⬇️
dandi/tests/test_bids_validator_xs.py 9.09% <0.00%> (-90.91%) ⬇️
dandi/support/tests/test_digests.py 16.66% <0.00%> (-83.34%) ⬇️
dandi/support/tests/test_iterators.py 13.15% <0.00%> (-81.58%) ⬇️
dandi/cli/tests/test_ls.py 21.05% <0.00%> (-78.95%) ⬇️
dandi/tests/test_validate.py 22.22% <0.00%> (-77.78%) ⬇️
dandi/tests/test_pynwb_utils.py 20.00% <0.00%> (-77.78%) ⬇️
dandi/cli/tests/test_formatter.py 22.22% <0.00%> (-77.78%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ee4dd...20ecaac. Read the comment docs.

@yarikoptic
Copy link
Member

I think there is no side effects but didn't check -- let's see in master

@yarikoptic yarikoptic merged commit 431a533 into master Apr 21, 2022
@yarikoptic yarikoptic deleted the strip-server-slash branch April 21, 2022 14:21
@github-actions
Copy link

🚀 PR was released in 0.39.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants