Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test config #957

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Integration test config #957

merged 2 commits into from
Apr 12, 2022

Conversation

dchiquito
Copy link
Contributor

@dchiquito dchiquito commented Apr 12, 2022

These changes may possibly help resolve dandi/dandi-archive#567.

  • Limit celery concurrency to 1. Possibly having multiple workers running at the same time is causing a race condition.
  • Upgrade the minio image version. The error might be happening when querying the minio container from the celery container, so possibly there is a minio bug that has been patched in the last 4 months.

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #957 (eb32c4b) into master (acc312c) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   87.28%   87.33%   +0.04%     
==========================================
  Files          65       65              
  Lines        8099     8099              
==========================================
+ Hits         7069     7073       +4     
+ Misses       1030     1026       -4     
Flag Coverage Δ
unittests 87.33% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/utils.py 81.26% <0.00%> (+0.31%) ⬆️
dandi/tests/skip.py 89.06% <0.00%> (+4.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc312c...eb32c4b. Read the comment docs.

@dchiquito dchiquito requested a review from jwodder April 12, 2022 20:24
@jwodder jwodder merged commit 78230ac into master Apr 12, 2022
@jwodder jwodder deleted the integration-test-config branch April 12, 2022 20:25
@github-actions
Copy link

🚀 PR was released in 0.39.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants