Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated HTTP404Error exception class #908

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Add dedicated HTTP404Error exception class #908

merged 1 commit into from
Feb 14, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 14, 2022

This cuts down on a lot of simple repetition by adding a dedicated HTTP404Error exception class subclassing requests.HTTPError that is used specifically for 404 errors.

@jwodder jwodder added the internal Changes only affect the internal API label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #908 (3b69708) into master (de4ff71) will increase coverage by 0.05%.
The diff coverage is 65.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   86.74%   86.79%   +0.05%     
==========================================
  Files          61       61              
  Lines        7447     7424      -23     
==========================================
- Hits         6460     6444      -16     
+ Misses        987      980       -7     
Flag Coverage Δ
unittests 86.79% <65.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 89.69% <62.50%> (+1.30%) ⬆️
dandi/exceptions.py 100.00% <100.00%> (ø)
dandi/dandiarchive.py 82.37% <0.00%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4ff71...3b69708. Read the comment docs.

@yarikoptic
Copy link
Member

LGTM, thank you!

@yarikoptic yarikoptic merged commit 1ca57a6 into master Feb 14, 2022
@yarikoptic yarikoptic deleted the status-exc branch February 14, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants