Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a pydantic model to store a RemoteDandiset's cached data #876

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 25, 2022

No description provided.

@jwodder jwodder added the internal Changes only affect the internal API label Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #876 (93d9037) into master (f3c62a3) will decrease coverage by 0.02%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
- Coverage   86.38%   86.36%   -0.03%     
==========================================
  Files          58       58              
  Lines        6097     6101       +4     
==========================================
+ Hits         5267     5269       +2     
- Misses        830      832       +2     
Flag Coverage Δ
unittests 86.36% <96.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 89.64% <96.15%> (-1.13%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c62a3...93d9037. Read the comment docs.

@jwodder jwodder mentioned this pull request Jan 25, 2022
@yarikoptic
Copy link
Member

Looks LGTM.

ubuntu test failures (https://github.com/dandi/dandi-cli/runs/4938998619?check_suite_focus=true) are probably unrelated but I got curious -- why there is a long list of

DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
DEBUG    dandi:dandiapi.py:256 Response: 200
DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
DEBUG    dandi:dandiapi.py:256 Response: 200

GET/responses to the same URL?

231 total
dandi@drogon:~/cronlib/tinuous-logs/dandi-cli/2022/01/25$ git grep 'GET http://localhost:8000/api/dandisets/000056/versions/draft/info/' github/pr/876/93d9037/Tests/3261/6_test\ \(ubuntu-18.04\,\ 3.9\,\ normal\).txt | nl | tail
   222	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6488193Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   223	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6488869Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   224	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6489525Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   225	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6490241Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   226	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6490906Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   227	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6491558Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   228	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6492214Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   229	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6492882Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   230	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6493537Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/
   231	github/pr/876/93d9037/Tests/3261/6_test (ubuntu-18.04, 3.9, normal).txt:2022-01-25T15:47:00.6494187Z DEBUG    dandi:dandiapi.py:211 GET http://localhost:8000/api/dandisets/000056/versions/draft/info/

@jwodder
Copy link
Member Author

jwodder commented Jan 25, 2022

@yarikoptic The failures are yet another instance of dandi/dandi-archive#567, in which assets fail to validate in time. The repeated requests are the client polling the valiation status until the two minute time limit is exceeded.

@yarikoptic yarikoptic merged commit 76a2f32 into master Jan 25, 2022
@yarikoptic yarikoptic deleted the remote-dandiset-data branch January 25, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants