Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wrapper function for the calls to find_files() in tests #860

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 10, 2022

So that I don't have to keep writing sorted(map(Path, find_files(r".*", [dirpath])))

@jwodder jwodder added the internal Changes only affect the internal API label Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #860 (0e9bbed) into master (f5d31a5) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   86.33%   86.30%   -0.04%     
==========================================
  Files          58       58              
  Lines        6030     6024       -6     
==========================================
- Hits         5206     5199       -7     
- Misses        824      825       +1     
Flag Coverage Δ
unittests 86.30% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_dandiapi.py 100.00% <100.00%> (ø)
dandi/tests/test_delete.py 100.00% <100.00%> (ø)
dandi/tests/test_download.py 100.00% <100.00%> (ø)
dandi/tests/test_upload.py 100.00% <100.00%> (ø)
dandi/utils.py 79.67% <100.00%> (+0.13%) ⬆️
dandi/dandiapi.py 89.57% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5d31a5...0e9bbed. Read the comment docs.

@jwodder jwodder added tests Add or improve existing tests and removed tests Add or improve existing tests labels Jan 10, 2022
@yarikoptic
Copy link
Member

coolio -- I am all for reducing code duplication!

@yarikoptic yarikoptic merged commit 98b59c2 into master Jan 10, 2022
@yarikoptic yarikoptic deleted the list-paths branch January 10, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants