Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generatorify.py #850

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Remove generatorify.py #850

merged 1 commit into from
Dec 13, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Dec 13, 2021

  • generator_from_callback() hasn't been used since we removed the Girder code. If we need something like it again, we can use callback_iter() from more-itertools.
  • callback_from_generator() has never been used.

@jwodder jwodder added the internal Changes only affect the internal API label Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #850 (96e82eb) into master (ca8d8c5) will increase coverage by 1.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   85.63%   86.64%   +1.00%     
==========================================
  Files          61       60       -1     
  Lines        6280     6193      -87     
==========================================
- Hits         5378     5366      -12     
+ Misses        902      827      -75     
Flag Coverage Δ
unittests 86.64% <ø> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/download.py 82.44% <0.00%> (-0.54%) ⬇️
dandi/dandiapi.py 89.69% <0.00%> (-0.18%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8d8c5...96e82eb. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 13, 2021

This pull request fixes 1 alert when merging 96e82eb into ca8d8c5 - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'

@yarikoptic
Copy link
Member

thanks, let's proceed!

@yarikoptic yarikoptic merged commit 2f3acab into master Dec 13, 2021
@yarikoptic yarikoptic deleted the rm-generatorify branch December 13, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants