Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the resource classes api_url properties #816

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Give the resource classes api_url properties #816

merged 1 commit into from
Oct 25, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 25, 2021

I was getting annoyed by having to type out API URLs the long way.

This PR also fixes the URL parsing to accept API URLs with trailing slashes and adds tests to ensure that all API URL formats are accepted with & without trailing slashes.

@jwodder jwodder added the minor Increment the minor version when merged label Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #816 (319d27e) into master (3fcc02d) will increase coverage by 0.03%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   84.69%   84.72%   +0.03%     
==========================================
  Files          61       61              
  Lines        6188     6201      +13     
==========================================
+ Hits         5241     5254      +13     
  Misses        947      947              
Flag Coverage Δ
unittests 84.72% <97.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiarchive.py 83.83% <ø> (ø)
dandi/tests/test_dandiarchive.py 100.00% <ø> (ø)
dandi/dandiapi.py 86.59% <91.66%> (+0.28%) ⬆️
dandi/tests/test_dandiapi.py 100.00% <100.00%> (ø)
dandi/tests/test_delete.py 100.00% <100.00%> (ø)
dandi/tests/test_download.py 100.00% <100.00%> (ø)
dandi/tests/test_upload.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814fa6f...319d27e. Read the comment docs.

@yarikoptic
Copy link
Member

Looks good, thanks!

@yarikoptic yarikoptic merged commit 1620fcd into master Oct 25, 2021
@yarikoptic yarikoptic deleted the api-url branch October 25, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants