-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give validate
command an --allow-any-path
option
#783
Conversation
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
- Coverage 85.22% 85.05% -0.18%
==========================================
Files 59 59
Lines 6039 6041 +2
==========================================
- Hits 5147 5138 -9
- Misses 892 903 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -28,7 +28,8 @@ def validate(paths, schema_version=None, devel_debug=False): | |||
path, errors | |||
errors for a path | |||
""" | |||
for path in find_dandi_files(paths): | |||
filepaths = find_files(".*", paths) if allow_any_path else find_dandi_files(paths) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I thought to suggest adding exclude_datalad=True
but since we already default to exclude_dotdirs = True
I guess that doesn't matter.
need to think whether we would like to make |
validate
command validate all files, not just .nwb'svalidate
command an --allow-any-path
option
@yarikoptic Done. |
Thank you @jwodder ... let's proceed with this and release to please dandischema testing with all the fixes we piled up. |
note -- there is one failing test run (ubuntu-18.04, 3.7, dev-deps) with
but it can't relate to this PR, so proceeding |
Closes #780.