Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an AttributeError raised when a URL is used as a species #782

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 4, 2021

No description provided.

@jwodder jwodder added the patch Increment the patch version when merged label Oct 4, 2021
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #782 (731686c) into master (27dd3e7) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   85.22%   85.04%   -0.19%     
==========================================
  Files          59       59              
  Lines        6039     6039              
==========================================
- Hits         5147     5136      -11     
- Misses        892      903      +11     
Flag Coverage Δ
unittests 85.04% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_metadata.py 100.00% <ø> (ø)
dandi/metadata.py 82.17% <100.00%> (+2.50%) ⬆️
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/dandiarchive.py 82.23% <0.00%> (-1.53%) ⬇️
dandi/download.py 81.69% <0.00%> (-0.55%) ⬇️
dandi/dandiapi.py 92.46% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27dd3e7...731686c. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you @jwodder! Could you please adjust the title to summarize actual change/fix so it could be self sufficient in CHANGELOG etc.

@jwodder jwodder changed the title Fix a bug exposed by #780 Fix an AttributeError raised when a URL is used as a species Oct 4, 2021
@jwodder
Copy link
Member Author

jwodder commented Oct 4, 2021

@yarikoptic Adjusted.

@yarikoptic
Copy link
Member

cool, thank you! Let's proceed. I will not rush to release ATM

@yarikoptic yarikoptic merged commit 023e059 into master Oct 4, 2021
@yarikoptic yarikoptic deleted the capitalize-bug branch October 4, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants