Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give RemoteAsset a created attribute #781

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Give RemoteAsset a created attribute #781

merged 2 commits into from
Oct 6, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 1, 2021

Motivated by dandi/dandisets#84.

@jwodder jwodder added the minor Increment the minor version when merged label Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #781 (4eee910) into master (27dd3e7) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   85.22%   85.11%   -0.11%     
==========================================
  Files          59       59              
  Lines        6039     6055      +16     
==========================================
+ Hits         5147     5154       +7     
- Misses        892      901       +9     
Flag Coverage Δ
unittests 85.11% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 92.49% <100.00%> (-0.17%) ⬇️
dandi/tests/test_dandiapi.py 100.00% <100.00%> (ø)
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/dandiarchive.py 82.23% <0.00%> (-1.53%) ⬇️
dandi/tests/test_metadata.py 100.00% <0.00%> (ø)
dandi/cli/cmd_validate.py 85.00% <0.00%> (+0.38%) ⬆️
dandi/validate.py 53.48% <0.00%> (+0.54%) ⬆️
dandi/metadata.py 82.17% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27dd3e7...4eee910. Read the comment docs.

dandi/dandiapi.py Outdated Show resolved Hide resolved
@jwodder jwodder changed the title Give RemoteAsset an optional created attribute Give RemoteAsset a created attribute Oct 4, 2021
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 6, 2021
@yarikoptic
Copy link
Member

ok, lets proceed and release this. Thank you @jwodder

@yarikoptic yarikoptic merged commit c9f00c7 into master Oct 6, 2021
@yarikoptic yarikoptic deleted the asset-created branch October 6, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants