Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify DJANGO_DANDI_VALIDATION_JOB_INTERVAL #778

Merged
merged 4 commits into from
Sep 30, 2021

Conversation

dchiquito
Copy link
Contributor

dandi/dandi-archive#538 is adding a scheduled job
which checks for Versions that need validation and validates them. The
default wait interval is 60 seconds, but it is configurable through an
environment variable, DJANGO_DANDI_VALIDATION_JOB_INTERVAL. Set this
environment variable to 5 so that the validation job runs every 5
seconds, which should be quick enough for wait_until_valid.

dandi/dandi-archive#538 is adding a scheduled job
which checks for Versions that need validation and validates them. The
default wait interval is 60 seconds, but it is configurable through an
environment variable, `DJANGO_DANDI_VALIDATION_JOB_INTERVAL`. Set this
environment variable to `5` so that the validation job runs every 5
seconds, which should be quick enough for `wait_until_valid`.
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #778 (177e878) into master (532ec1c) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   85.07%   84.90%   -0.17%     
==========================================
  Files          59       59              
  Lines        6042     6042              
==========================================
- Hits         5140     5130      -10     
- Misses        902      912      +10     
Flag Coverage Δ
unittests 84.90% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/dandiapi.py 92.46% <0.00%> (-0.20%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532ec1c...177e878. Read the comment docs.

@dchiquito dchiquito merged commit fd0ee3c into master Sep 30, 2021
@dchiquito dchiquito deleted the enh-dandi-api-validation-interval branch September 30, 2021 20:08
@jwodder jwodder added the tests Add or improve existing tests label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants