Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of Dandiset validation errors #777

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 27, 2021

Split off from #775

@jwodder jwodder added the patch Increment the patch version when merged label Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #777 (9774952) into master (7bba7ff) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
- Coverage   85.08%   84.90%   -0.18%     
==========================================
  Files          59       59              
  Lines        6040     6041       +1     
==========================================
- Hits         5139     5129      -10     
- Misses        901      912      +11     
Flag Coverage Δ
unittests 84.90% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 92.46% <0.00%> (-0.39%) ⬇️
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bba7ff...9774952. Read the comment docs.

@yarikoptic
Copy link
Member

thank you!

@yarikoptic yarikoptic merged commit c3305d5 into master Sep 27, 2021
@yarikoptic yarikoptic deleted the validation-error branch September 27, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants