Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip shell completion test entirely on Windows #702

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 8, 2021

It just doesn't work on conda-forge.

@jwodder jwodder added the tests Add or improve existing tests label Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #702 (362887e) into master (31cf2e5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   83.99%   84.06%   +0.06%     
==========================================
  Files          59       59              
  Lines        5668     5665       -3     
==========================================
+ Hits         4761     4762       +1     
+ Misses        907      903       -4     
Flag Coverage Δ
unittests 84.06% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/tests/test_shell_completion.py 100.00% <100.00%> (+9.09%) ⬆️
dandi/dandiapi.py 90.37% <0.00%> (-0.54%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cf2e5...362887e. Read the comment docs.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Jul 8, 2021
@yarikoptic
Copy link
Member

ok, let's please conda's anti-windows Gods and try with new release

@yarikoptic yarikoptic merged commit 12a3623 into master Jul 8, 2021
@yarikoptic yarikoptic deleted the skip-windows branch July 8, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants