-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ls --schema: Calculate digest for local assets #666
Conversation
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 83.62% 84.12% +0.50%
==========================================
Files 59 59
Lines 5379 5606 +227
==========================================
+ Hits 4498 4716 +218
- Misses 881 890 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
this works for me. two potential enhancements:
|
@satra Done. |
dandi/cli/cmd_ls.py
Outdated
@@ -60,9 +60,23 @@ | |||
help="Convert metadata to new schema version", | |||
metavar="VERSION", | |||
) | |||
@click.option( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm fine with it being a DEVEL option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then some kind of output should say "computing checksum" - the pyout output on drogon is not super helpful for me (number of rows displayed, etc.,.). so perhaps a status field could be added that gives such info in a column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displaying some message is orthogonal to having digest fake or not (that is what the option is about).
why are you interested to get that displayed BTW? I guess we could add some lgr.debug
into get_digest for that purpose. We have "mothballed for now" #465 to display digest computing progress during upload. May be after/during Python API refactoring we could come up with some consistent interface across commands to display progress of long going operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the option devel-only and added an INFO-level log message just before calculating a digest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just that you have no idea as a user what the program is doing when showing ls. just like upload says validating, uploading, complete, it would be nice at least in the pyout display to know that something is going on.
ok, let's merge this and release a fresh release of the dandi-cli |
Fixes #665.