Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of json_dict() method #526

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Add tests of json_dict() method #526

merged 2 commits into from
Mar 30, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 30, 2021

This PR adds tests of the json_dict() method to test_metadata.py so that we can be sure it generates what we expect and won't drop schemaKeys again.

This PR includes #525.

@jwodder jwodder added the tests Add or improve existing tests label Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #526 (90d24dd) into master (a6a4a0f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   83.49%   83.52%   +0.02%     
==========================================
  Files          62       62              
  Lines        6418     6428      +10     
==========================================
+ Hits         5359     5369      +10     
  Misses       1059     1059              
Flag Coverage Δ
unittests 83.52% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_metadata.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a4a0f...90d24dd. Read the comment docs.

@yarikoptic yarikoptic merged commit 08a14ff into master Mar 30, 2021
@yarikoptic yarikoptic deleted the json-dict-test branch March 30, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants