Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better filtering of file-only log messages #523

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 29, 2021

This PR modifies the way that logfile-only log messages are filtered out from the stderr logs to be more robust/standard/"the right way to do things" — specifically, by filtering on a custom extra log record attribute instead of the log message.

@jwodder jwodder added the patch Increment the patch version when merged label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #523 (21f0a10) into master (0e63181) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   83.32%   83.32%           
=======================================
  Files          62       62           
  Lines        6382     6382           
=======================================
  Hits         5318     5318           
  Misses       1064     1064           
Flag Coverage Δ
unittests 83.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/command.py 46.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e63181...21f0a10. Read the comment docs.

@yarikoptic yarikoptic merged commit f9843e8 into master Mar 29, 2021
@yarikoptic yarikoptic deleted the fix-file-filter branch March 29, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants