Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted code cleanup #422

Merged
merged 6 commits into from
Feb 25, 2021
Merged

Assorted code cleanup #422

merged 6 commits into from
Feb 25, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 25, 2021

This is a collection of minor edits to the code that aren't really worth their own PRs. See each commit for descriptions of the changes.

@jwodder jwodder added the internal Changes only affect the internal API label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #422 (756506c) into master (1cc2043) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   82.25%   82.26%   +0.01%     
==========================================
  Files          55       55              
  Lines        5679     5671       -8     
==========================================
- Hits         4671     4665       -6     
+ Misses       1008     1006       -2     
Flag Coverage Δ
unittests 82.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/__init__.py 72.72% <ø> (-1.19%) ⬇️
dandi/dandiset.py 85.89% <100.00%> (-0.18%) ⬇️
dandi/tests/test_organize.py 93.60% <100.00%> (ø)
dandi/utils.py 75.94% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc2043...756506c. Read the comment docs.

@@ -21,8 +21,6 @@ description = Command line client for interaction with DANDI archive elements
long_description = file:README.md
long_description_content_type = text/markdown; charset=UTF-8
platforms = OS Independent
provides =
dandi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious: where it potentially could be used? I found no description on https://packaging.python.org/guides/distributing-packages-using-setuptools

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in the ecosystem currently uses this field. There are occasional discussions around using "Provides" to implement support for things like virtual packages, but nothing ever comes of it.

@yarikoptic
Copy link
Member

Looks good. Just curious about "provides". Let's proceed

@yarikoptic yarikoptic merged commit 41000ee into master Feb 25, 2021
@yarikoptic yarikoptic deleted the cleanup-code branch February 25, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants