-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted code cleanup #422
Conversation
No part of the packaging infrastructure uses that field.
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 82.25% 82.26% +0.01%
==========================================
Files 55 55
Lines 5679 5671 -8
==========================================
- Hits 4671 4665 -6
+ Misses 1008 1006 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -21,8 +21,6 @@ description = Command line client for interaction with DANDI archive elements | |||
long_description = file:README.md | |||
long_description_content_type = text/markdown; charset=UTF-8 | |||
platforms = OS Independent | |||
provides = | |||
dandi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious: where it potentially could be used? I found no description on https://packaging.python.org/guides/distributing-packages-using-setuptools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing in the ecosystem currently uses this field. There are occasional discussions around using "Provides" to implement support for things like virtual packages, but nothing ever comes of it.
Looks good. Just curious about "provides". Let's proceed |
This is a collection of minor edits to the code that aren't really worth their own PRs. See each commit for descriptions of the changes.