Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATALAD RUNCMD] Swap order of str and AnyUrl to be from specific to generic #334

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

yarikoptic
Copy link
Member

See #333 for more information/reasoning

…generic

See #333 for more information

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "sed -i -e 's/str, AnyUrl/AnyUrl, str/g' {inputs}",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [
  "dandi/models.py"
 ],
 "outputs": [
  "dandi/models.py"
 ],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic yarikoptic requested a review from satra January 20, 2021 21:12
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #334 (98b0719) into master (21b7c84) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   82.38%   82.37%   -0.02%     
==========================================
  Files          55       55              
  Lines        5105     5105              
==========================================
- Hits         4206     4205       -1     
- Misses        899      900       +1     
Flag Coverage Δ
unittests 82.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/models.py 82.35% <100.00%> (ø)
dandi/dandiapi.py 82.09% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b7c84...98b0719. Read the comment docs.

@satra satra merged commit fe3b74e into master Jan 21, 2021
@satra satra deleted the rf-anyurl branch January 21, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants