Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry test that intermittently fails on NFS #1290

Merged
merged 1 commit into from
May 17, 2023
Merged

Retry test that intermittently fails on NFS #1290

merged 1 commit into from
May 17, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 17, 2023

test_files.py::test_dandi_file_zarr_with_excluded_dotfiles keeps intermittently failing on NFS, so this PR uses pytest-rerunfailures to rerun it up to ten times until it succeeds.

@jwodder jwodder added the tests Add or improve existing tests label May 17, 2023
@jwodder jwodder marked this pull request as ready for review May 17, 2023 16:16
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (84ec4f8) 89.02% compared to head (302079b) 89.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
+ Coverage   89.02%   89.08%   +0.06%     
==========================================
  Files          76       76              
  Lines        9896     9897       +1     
==========================================
+ Hits         8810     8817       +7     
+ Misses       1086     1080       -6     
Flag Coverage Δ
unittests 89.08% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_files.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

heh heh. reminds me of good old times of PyMVPA and our @labile helper https://github.com/PyMVPA/PyMVPA/blob/master/mvpa2/testing/tools.py#L403 . Ok, let's hope it helps

image

@yarikoptic yarikoptic merged commit 12ccc98 into master May 17, 2023
@yarikoptic yarikoptic deleted the flaky-nfs branch May 17, 2023 20:27
@github-actions
Copy link

🚀 PR was released in 0.55.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants