Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected docstring #1245

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Corrected docstring #1245

merged 1 commit into from
Mar 8, 2023

Conversation

TheChymera
Copy link
Contributor

Really minor fix I noticed while working on something else, hence the unfitting branch name.

@TheChymera TheChymera added the documentation Changes only affect the documentation label Mar 8, 2023
@TheChymera
Copy link
Contributor Author

The type check failure has nothing to do with this PR.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (75b2a39) 89.04% compared to head (c7686ec) 89.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   89.04%   89.01%   -0.04%     
==========================================
  Files          76       76              
  Lines        9698     9698              
==========================================
- Hits         8636     8633       -3     
- Misses       1062     1065       +3     
Flag Coverage Δ
unittests 89.01% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_validate.py 77.89% <ø> (ø)
dandi/support/threaded_walk.py 93.10% <0.00%> (-1.73%) ⬇️
dandi/misctypes.py 72.54% <0.00%> (-0.66%) ⬇️
dandi/metadata.py 89.22% <0.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

Thanks! type checking clearly must not relate!

@yarikoptic yarikoptic merged commit b2a3fda into master Mar 8, 2023
@yarikoptic yarikoptic deleted the severity branch March 8, 2023 15:27
@github-actions
Copy link

🚀 PR was released in 0.51.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants