Update for dandischema 0.8.0 #1241
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1241 +/- ##
==========================================
- Coverage 89.03% 89.03% -0.01%
==========================================
Files 76 76
Lines 9698 9709 +11
==========================================
+ Hits 8635 8644 +9
- Misses 1063 1065 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,6 +1,6 @@ | |||
| import sys | |||
|
|
|||
| if sys.version_info >= (3, 8): | |||
| from typing import Literal, TypedDict # noqa: F401 | |||
| from typing import Literal, Protocol, TypedDict # noqa: F401 | |||
Check notice
Code scanning / CodeQL
Unused import
| @@ -520,6 +520,14 @@ | |||
| } | |||
|
|
|||
|
|
|||
| class Hasher(Protocol): | |||
| def update(self, data: bytes) -> None: | |||
| ... | |||
Check notice
Code scanning / CodeQL
Statement has no effect
| ... | ||
|
|
||
| def hexdigest(self) -> str: | ||
| ... |
Check notice
Code scanning / CodeQL
Statement has no effect
|
type checking isn't happy. |
|
@yarikoptic The CI will use a Docker image built from the latest commit to |
|
typechecking is still red |
|
archive released an update setting minimium version to |
It's true, the CI tests upload to staging. Just wanted you to be aware as soon as it happened so same doesn't happen to the main server |
|
pushed fix for typing |
|
I dislike our too rigid dependency on versions correspondence... we should reconsider. |
|
🚀 PR was released in |
Blocked by dandi/dandi-archive#1520.
There are still some typing errors that will be resolved once dandi/dandi-schema#163 is merged & released.
Closes #1249