skip test_nwb2asset_remote_asset if no fsspec installed #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsspec installed only in "[extras]" extra_requires, so not by default. I tested that it is enough of "pip install fsspec" without "[http]" extras and test passes then
yarikoptic
added
release
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
+ Coverage 89.13% 89.18% +0.05%
==========================================
Files 74 74
Lines 9617 9618 +1
==========================================
+ Hits 8572 8578 +6
+ Misses 1045 1040 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jwodder
approved these changes
Mar 3, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsspec installed only in "[extras]" extra_requires, so not by default. I tested that it is enough of "pip install fsspec" without "[http]" extras and test passes then.
Discovered needed while downstream testing dandi/dandi-schema#100 . Since we are installing
dandias released IIRC also for downstream in dandi-archive, I am marking this one for release so we get green again.