Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for ls reinstated, underlying function fixed, support for ZARR-BIDS files added. #1164

Merged
merged 37 commits into from
Dec 12, 2022
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d3ec5f1
Unravelling `ls` issues
TheChymera Nov 23, 2022
dc34ab0
strange `Cannot creat weak reference to PosixPath object`
TheChymera Nov 23, 2022
8aef541
Fixed weakref issue
TheChymera Nov 28, 2022
b3a4b9a
Added readme listing and removed some diagnostic print calls
TheChymera Nov 28, 2022
3272c86
Removed more debugging print calls
TheChymera Nov 28, 2022
ba99146
Removed more debugging print calls
TheChymera Nov 28, 2022
64677c1
Creating and passing digests
TheChymera Nov 28, 2022
f8a0da8
Added validation bids schema version to result object metadata
TheChymera Nov 28, 2022
430fb06
Assigning bids schema version for validation to metadata dict
TheChymera Nov 28, 2022
279ecf9
Trying to insert bids_schema_version ... somewhere.
TheChymera Nov 29, 2022
60b2408
Added (get_validation)_bids_version to BIDS assets
TheChymera Nov 29, 2022
4a4530e
Creating ZARR digest for ZARR files
TheChymera Nov 30, 2022
9df52ad
Using correct ZARR digest class (still not working)
TheChymera Dec 1, 2022
0e0ff8e
More debugging print calls trying to track down digest error
TheChymera Dec 1, 2022
cc28fbb
Removed unneeded import
TheChymera Dec 1, 2022
5d59ae8
Using zarr extensions variable from constants module
TheChymera Dec 1, 2022
5d62fcc
Reinstated fake digest after introducing ZARR conditional
TheChymera Dec 1, 2022
f0de103
Attempting to fix digest type conflict (still not working)
TheChymera Dec 1, 2022
86ae9c0
Use Zarr checksum to set metadata contentSize
jwodder Dec 1, 2022
9866d0c
Removed debugging print calls
TheChymera Dec 2, 2022
785dec0
Not requiring bids_version for ValidatorOrigin
TheChymera Dec 2, 2022
2059dd7
Typing fixes and improved variable name
TheChymera Dec 2, 2022
a2119ec
Attemting type check fix for missing attribute
TheChymera Dec 2, 2022
722e804
Removed commented imports
TheChymera Dec 2, 2022
3649b5e
Actually fix typing
jwodder Dec 2, 2022
32d0379
Debugging upload tests
TheChymera Dec 2, 2022
ba7d60c
Reinstating test
TheChymera Dec 5, 2022
e8a64e1
Associate BIDS asset errors with the actual assets
jwodder Dec 5, 2022
ccda9ec
Fixed novel README validation error
TheChymera Dec 5, 2022
44a8ab4
Checking ls output subject identifier
TheChymera Dec 5, 2022
efab43e
Added ls command tests for zarrBIDS file
TheChymera Dec 5, 2022
1ed0f5f
ZARR-appropriate fake checksum
TheChymera Dec 6, 2022
9900841
More compact code
TheChymera Dec 6, 2022
3384ef5
Dot in extension
TheChymera Dec 6, 2022
d9ccf8b
Safer assert satatement
TheChymera Dec 6, 2022
375947d
Making sure the method which sets the attribute has been run
TheChymera Dec 6, 2022
11c18f5
Updated logic to better accommodate future BIDS NWB examples
TheChymera Dec 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Dot in extension
Co-authored-by: John T. Wodder II <[email protected]>
  • Loading branch information
TheChymera and jwodder committed Dec 6, 2022
commit 3384ef5d14bb8ac88f39946c25f3aa6b66694ebe
2 changes: 1 addition & 1 deletion dandi/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def get_metadata(
# We assume that non-NWB data is BIDS.
# This is currently the case, and is slated to change only when we have NWB data which
# is *also* BIDS.
if path.endswith(("NWB", "nwb")):
if path.endswith((".NWB", ".nwb")):
if nwb_has_external_links(path):
raise NotImplementedError(
f"NWB files with external links are not supported: {path}"
Expand Down