Test against Python 3.11 #1143
Test against Python 3.11 #1143
Conversation
Codecov ReportBase: 89.16% // Head: 89.16% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 74 74
Lines 9421 9421
=======================================
Hits 8400 8400
Misses 1021 1021
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
FTR according to changes in setup.py was added in around Aug but never released yet: edit: moved to draft since we can't act on it ATM and thus not ready for consideration |
jwodder
force-pushed
the
py3.11
branch
2 times, most recently
from
d8d710a to
1010b25
Compare
|
Current status: The latest version of nwbinspector requires |
Original commit which added those bounds (f0db1aa) provides no information on the rationale. But in my experience bounding like this is more of causing problems (if done within setup.py, but here setup.py just reuses what is in requirements.txt) down the road, although possibly providing momentary problem fixing at earlier time. ATM e.g. it complicates providing dandi-cli update for python 3.11 which @jwodder tried to accomplish, see dandi/dandi-cli#1143 (comment) for more detail
|
nwbinspector requires pynwb, which requires hdmf, which requires h5py, which also does not have wheels released for py3.11 last time I checked. We have an open PR for testing hdmf against py3.11 here: hdmf-dev/hdmf#803 but we will need to wait on numpy and h5py. In the meantime we are making the numpy requirements less strict on nwbinspector. |
|
Current status: Only the the Windows + Python 3.11 tests are failing, due to the same issue affecting Windows + Python 3.10 tests described here. |
|
@yarikoptic All tests pass now. |
|
Thank you @jwodder ! I wonder if we are doomed to add to https://github.com/dandi/dandi-cli#installation for now the need for such system wide dance for 3.11 to preclude possible user filed issues? |
|
@yarikoptic If you're referring to the need to install hdf5, that no longer seems to be necessary, as the latest version of h5py includes wheels for Python 3.11. |
|
oh, great, and we are still green -- let's proceed. Thank you @jwodder ! (as for added warning ignore -- ok with me, I just upgraded botocore - seems resolved it) |
Python 3.11 was released on October 24, so it's time to start testing against it.
Note: I expect this PR to fail for the next few weeks until numpy makes a 3.11-compatible release.