Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal Zarr-checksumming tree types support empty Zarrs #1138

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 13, 2022

@yarikoptic Please release this so I can use it in backups2datalad.

@jwodder jwodder added the internal Changes only affect the internal API label Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 87.92% // Head: 87.94% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f298c46) compared to base (4f50102).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
+ Coverage   87.92%   87.94%   +0.01%     
==========================================
  Files          73       73              
  Lines        8572     8584      +12     
==========================================
+ Hits         7537     7549      +12     
  Misses       1035     1035              
Flag Coverage Δ
unittests 87.94% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/tests/test_digest.py 100.00% <100.00%> (ø)
dandi/support/digests.py 100.00% <100.00%> (ø)
dandi/support/tests/test_digests.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

is an empty directory is a legit zarr and we will get those to archive? sorry if I am not seeing the connection (there is no reference) to other ongoing discussions.

@jwodder
Copy link
Member Author

jwodder commented Oct 14, 2022

@yarikoptic While the CLI will refuse to upload an empty Zarr, it's technically possible to create one via the API (including unintentionally if an upload is cancelled during the first batch), and the backups2datalad tests include backing up an empty Zarr.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 14, 2022
@yarikoptic
Copy link
Member

gotcha, invalid but still possible

@yarikoptic yarikoptic merged commit 1b971d6 into master Oct 14, 2022
@yarikoptic yarikoptic deleted the digest-empty-zarr branch October 14, 2022 18:34
@github-actions
Copy link

🚀 PR was released in 0.46.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants