Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: lgr.debug that we are using DANDI_API_KEY provided key #1133

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

yarikoptic
Copy link
Member

to possibly avoid confusions like
#1130

or should we go for .info?

Copy link
Member

@jwodder jwodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add corresponding "Using API key from keyring/user input" log messages around line 492.

dandi/dandiapi.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 87.92% // Head: 87.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9b82efd) compared to base (bcbf09b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
+ Coverage   87.92%   87.93%   +0.01%     
==========================================
  Files          73       73              
  Lines        8569     8571       +2     
==========================================
+ Hits         7534     7537       +3     
+ Misses       1035     1034       -1     
Flag Coverage Δ
unittests 87.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 88.26% <100.00%> (+0.03%) ⬆️
dandi/support/threaded_walk.py 94.64% <0.00%> (+1.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member Author

You might want to add corresponding "Using API key from keyring/user input" log messages around line 492.

good idea, did that+ -- please check

@yarikoptic yarikoptic merged commit 6f03b9c into master Oct 10, 2022
@yarikoptic yarikoptic deleted the enh-inform branch October 10, 2022 21:05
@github-actions
Copy link

🚀 PR was released in 0.46.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants