Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect link type for organize by linking from first src dir to dest dir #1115

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 15, 2022

Closes #1110.

@jwodder jwodder added the patch Increment the patch version when merged label Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 88.60% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1931c11) compared to base (e74c5ac).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
- Coverage   88.60%   88.59%   -0.02%     
==========================================
  Files          76       76              
  Lines        9108     9117       +9     
==========================================
+ Hits         8070     8077       +7     
- Misses       1038     1040       +2     
Flag Coverage Δ
unittests 88.59% <88.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/organize.py 82.81% <83.33%> (+0.06%) ⬆️
dandi/tests/test_organize.py 95.15% <100.00%> (+0.05%) ⬆️
dandi/files/bases.py 75.78% <0.00%> (-2.18%) ⬇️
dandi/support/threaded_walk.py 92.85% <0.00%> (-1.79%) ⬇️
dandi/upload.py 85.78% <0.00%> (-1.53%) ⬇️
dandi/metadata.py 87.02% <0.00%> (+1.01%) ⬆️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dandi/organize.py Outdated Show resolved Hide resolved

if len(paths) == 1 and paths[0].endswith(".json"):
# Our dumps of metadata
metadata = load_jsonl(paths[0])
link_test_file = metadata[0]["path"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principle AFAIK we do not even need link_test_file since we can simply use metadata[0]["path"] directly since we do load metadata records for regular paths too... but ok, let it be this way for now

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Sep 19, 2022
@yarikoptic
Copy link
Member

Thank you @jwodder and let's proceed!

@yarikoptic yarikoptic merged commit db4acbf into master Sep 19, 2022
@yarikoptic yarikoptic deleted the gh-1110 branch September 19, 2022 16:19
@github-actions
Copy link

🚀 PR was released in 0.46.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

organize - cannot move files on Windows across drives
2 participants