-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect link type for organize
by linking from first src dir to dest dir
#1115
Conversation
Codecov ReportBase: 88.60% // Head: 88.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
- Coverage 88.60% 88.59% -0.02%
==========================================
Files 76 76
Lines 9108 9117 +9
==========================================
+ Hits 8070 8077 +7
- Misses 1038 1040 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
||
if len(paths) == 1 and paths[0].endswith(".json"): | ||
# Our dumps of metadata | ||
metadata = load_jsonl(paths[0]) | ||
link_test_file = metadata[0]["path"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in principle AFAIK we do not even need link_test_file
since we can simply use metadata[0]["path"]
directly since we do load metadata records for regular paths too... but ok, let it be this way for now
Thank you @jwodder and let's proceed! |
🚀 PR was released in |
Closes #1110.