-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: describe the purpose for --instance in download #1053
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 71 71
Lines 9159 9159
=======================================
Hits 8097 8097
Misses 1062 1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dandi/cli/cmd_download.py
Outdated
help="Instance of DANDI archive to use. If URLs provided, we would ensure that " | ||
"they point to the same instance as specified. If no URLs provided, that " | ||
"instance will be used for identifier found in local dandiset.yaml.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rewording:
DANDI Archive instance to download from. If any URLs are provided, they must point to the given instance. If no URL is provided, and there is a local dandiset.yaml file, the Dandiset with the identifier given in the file will be downloaded from the given instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please send it as suggestion (select multiple lines before clicking on suggestion icon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed is better than mine, accepted
Co-authored-by: John T. Wodder II <[email protected]>
🚀 PR was released in |
attn @waxlamp -- is it better?