Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message formatting #1013

Merged
merged 1 commit into from
May 13, 2022
Merged

Fix error message formatting #1013

merged 1 commit into from
May 13, 2022

Conversation

JuliaSprenger
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #1013 (1b563de) into master (0016e60) will decrease coverage by 22.95%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #1013       +/-   ##
===========================================
- Coverage   87.67%   64.71%   -22.96%     
===========================================
  Files          65       65               
  Lines        8187     8098       -89     
===========================================
- Hits         7178     5241     -1937     
- Misses       1009     2857     +1848     
Flag Coverage Δ
unittests 64.71% <0.00%> (-22.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/download.py 67.59% <0.00%> (-19.66%) ⬇️
dandi/tests/test_upload.py 20.95% <0.00%> (-79.05%) ⬇️
dandi/tests/test_delete.py 22.69% <0.00%> (-77.31%) ⬇️
dandi/upload.py 9.64% <0.00%> (-76.22%) ⬇️
dandi/tests/test_helpers.py 25.00% <0.00%> (-75.00%) ⬇️
dandi/tests/test_dandiapi.py 26.59% <0.00%> (-73.41%) ⬇️
dandi/delete.py 30.51% <0.00%> (-60.45%) ⬇️
dandi/tests/test_dandiarchive.py 40.67% <0.00%> (-59.33%) ⬇️
dandi/tests/test_download.py 45.00% <0.00%> (-55.00%) ⬇️
dandi/conftest.py 52.94% <0.00%> (-47.06%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0016e60...1b563de. Read the comment docs.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (0016e60) to head (1b563de).
Report is 1115 commits behind head on master.

Files Patch % Lines
dandi/download.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
- Coverage   87.67%   87.65%   -0.03%     
==========================================
  Files          65       65              
  Lines        8187     8187              
==========================================
- Hits         7178     7176       -2     
- Misses       1009     1011       +2     
Flag Coverage Δ
unittests 87.65% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder added the patch Increment the patch version when merged label May 13, 2022
@jwodder jwodder merged commit e7784a8 into dandi:master May 13, 2022
@github-actions
Copy link

🚀 PR was released in 0.40.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants