RF: remove dance of str/Path while passing file_path into _pydantic_e…

…rrors_to_validation_results Thanks @jwodder for the review
dandi · Feb 8, 2023 · b6f8180 · b6f8180
1 parent 59cc420
commit b6f8180
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/dandi/files/bases.py b/dandi/files/bases.py
@@ -131,7 +131,7 @@ def get_validation_errors(
                 if devel_debug:
                     raise
                 return _pydantic_errors_to_validation_results(
-                    [e], str(self.filepath), scope=Scope.DANDISET
+                    [e], self.filepath, scope=Scope.DANDISET
                 )
             return []
 
@@ -186,7 +186,7 @@ def get_validation_errors(
             if devel_debug:
                 raise
             return _pydantic_errors_to_validation_results(
-                e, str(self.filepath), scope=Scope.FILE
+                e, self.filepath, scope=Scope.FILE
             )
         except Exception as e:
             if devel_debug:
@@ -535,7 +535,7 @@ def get_validation_errors(
                     raise
                 # TODO: might reraise instead of making it into an error
                 return _pydantic_errors_to_validation_results(
-                    [e], str(self.filepath), scope=Scope.FILE
+                    [e], self.filepath, scope=Scope.FILE
                 )
 
         from .bids import NWBBIDSAsset
@@ -740,7 +740,7 @@ def _get_nwb_inspector_version():
 
 def _pydantic_errors_to_validation_results(
     errors: list[dict | Exception] | ValidationError,
-    file_path: str,
+    file_path: Path,
     scope: Scope,
 ) -> list[ValidationResult]:
     """Convert list of dict from pydantic into our custom object."""
@@ -773,7 +773,7 @@ def _pydantic_errors_to_validation_results(
                 severity=Severity.ERROR,
                 id=id,
                 scope=scope,
-                path=Path(file_path),
+                path=file_path,
                 message=message,
                 # TODO? dataset_path=dataset_path,
                 # TODO? dandiset_path=dandiset_path,