Show binary files changes in delta output

[gibfahn]

When I use GIT_PAGER=less git show I see the following section for each binary file:

diff --git a/foo b/foo
new file mode 100644
index 0000000..4088911
Binary files /dev/null and b/foo differ

When I use delta with GIT_PAGER="delta --theme=TwoDark" git show, I don't see any output for foo, which is a binary file.

It would be great to see something that shows that there was a binary file and that it has changed, what less shows would be fine.

Quick repro:

mkdir -p tst && cd tst
git init
echo -n -e \\x48\\x00\\x49\\x00 > foo
git add foo
GIT_PAGER="delta --theme=TwoDark" git diff --staged
GIT_PAGER=less git diff --staged

Output:

$ mkdir -p tst && cd tst
$ git init
Initialized empty Git repository in ~/tmp/tst/.git/
$ echo -n -e \\x48\\x00\\x49\\x00 > foo
$ git add foo
$ GIT_PAGER="delta --theme=TwoDark" git diff --staged
$ GIT_PAGER=less git diff --staged
  diff --git a/foo b/foo
  new file mode 100644
  index 0000000..7a42ff1
  Binary files /dev/null and b/foo differ

Thanks for making such a great diff viewer by the way, best one I've found hands down.

[dandavison]

Thanks for reporting this and thanks for the reproduction script. I've fixed this in #94, and added a test. However, as noted in that PR, I am currently confused about why the test is passing before the fix commit. If you do have a local rust setup and feel like building on that branch to confirm the fix that would be great, but no worries if not and thanks for the report!

[Kr1ss-XD]

FWIW, I just checked out #94 and rebuilt; on my end this issue is fixed.

Looks good to me, thx ! 👍

[gibfahn]

Checked and it works, thanks for fixing it so quickly!