Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File paths with spaces in them truncated #127

Closed
nzbart opened this issue Apr 24, 2020 · 3 comments · Fixed by #129
Closed

File paths with spaces in them truncated #127

nzbart opened this issue Apr 24, 2020 · 3 comments · Fixed by #129

Comments

@nzbart
Copy link

nzbart commented Apr 24, 2020

This plugin is great, but unfortunately is mostly unusable in repositories that have paths with spaces in them.

I'm running version 0.0.18.

If I create the following structure:

.
├── nospace
│   └── file2
└── with space
    └── file1

I get the following diff output:

image

As you can see, the file path that contains a space is truncated at with. This means that it's impossible to know what file the diff applies to underneath that directory.

@nzbart nzbart changed the title File paths with spaces in them not shown File paths with spaces in them truncated Apr 24, 2020
dandavison added a commit that referenced this issue Apr 26, 2020
dandavison added a commit that referenced this issue Apr 26, 2020
@dandavison
Copy link
Owner

Thanks very much @nzbart! This is fixed in master; I intend to make a release soon.

commit 41a99ec49005ca97c9276b752275329996d147d0 (HEAD -> master)
Author: Dan Davison <[email protected]>
Date:   Sun Apr 26 18:34:52 2020 -0400

    Initial commit

diff --git a/nospace/file2 b/nospace/file2
new file mode 100644
index 0000000..af1b8ae
--- /dev/null
+++ b/nospace/file2
@@ -0,0 +1 @@
+file2 contents
diff --git a/with space/file1 b/with space/file1
new file mode 100644
index 0000000..84d55c5
--- /dev/null
+++ b/with space/file1  
@@ -0,0 +1 @@
+file1 contents
commit 487933aa5b8dd0f9d89464b275eccd0239ddd9b0
Author: Dan Davison <[email protected]>
Date:   Sun Apr 26 18:35:43 2020 -0400

    Initial commit


added: nospace/file2
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

1 
 file2 contents                                                                                                                                                                                                 

added: with space/file1 
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

1 
 file1 contents      

@nzbart
Copy link
Author

nzbart commented Apr 26, 2020

I downloaded and tested master, and can confirm that the problem is fixed there.

Thanks!

@dandavison
Copy link
Owner

And thanks also for doing that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants