🐛 git grep handler doesn't highlight matches that start in column 0

[jdpopkin]

Hi! It looks like the git grep handler can't highlight the grep-match if the grep-match starts at the beginning of the line of code. I'm not sure if this is always the case or if it's specific to my type of terminal in some way (I'm using Terminal.app on macOS).

To repro,

mkdir /tmp/delta-test
cd /tmp/delta-test
echo 'foo' > broken.md
echo '...foo' > working.md
git init
git add .
git commit -m 'Add files to repro bug'
git grep 'foo'

On my machine, that leaves us with one line where foo is highlighted (working.md) and another line where it is not (broken.md):

Not a big deal for a trivial case like this (where the entire line matches the query exactly), but with a more complicated regex it can be annoying.

I have a fix for this. It's a little bit weird, but I think it should be okay.

• Please include the raw text output from git, so that we can reproduce the problem.
  The problem is in handling of ANSI color codes, which I suspect cannot be pasted here? But here's a cat -v representation of what GIT_PAGER=less git color.grep=always grep 'foo' does here:

broken.md^[[36m:^[[m1^[[36m:^[[m^[[1;31mfoo^[[m
working.md^[[36m:^[[m1^[[36m:^[[m...^[[1;31mfoo^[[m

(Pretty hard to visually parse this, but: it highlights "foo" correctly on both lines.)

• A screenshot of Delta's output is often helpful also.

Thanks for filing a Delta bug report!