Deal with ppValue == ppThresh scenario

[chrskly]

There's a possible bug here. The code deals with ppValue < ppThresh and ppValue > ppThresh but not ppValue == ppThresh. It's probably not likely that this would occur often, but it could lead weird behavior when ppValue is near ppThresh. Noise could possibly produce irratic results. E.g., plug in first time, charge fails, plug in second time, charge succeeds.

I've set the == condition on the positive side because I think that is what the user expectation would be.

Another option would be to set the == on the negative side.

Yet another option would be to remove the if (ppValue > ppThresh) condition from the else block.

[damienmaguire]

Has this been tested? Thanks

[chrskly]

No, I don't have the means to test it right now. I'm just reading through the code to get an understanding of how it works and noticed that there's a gap here.

The change just substitutes a < for a <= to catch every possible value of ppValue. Should be a relatively safe change.

[Tom-evnut]

Agree, this is the "correct" way of defining.

[chrskly]

Cheers!