LEAF PDM/Inverter: Unify MPRUN handling to save memory #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalathegreat
requested review from
damienmaguire and
jsphuebner
as code owners
Simplify MPRUN, move 50B message to 100ms
dalathegreat
changed the title
damienmaguire
approved these changes
Dec 5, 2024
|
Thanks Dala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR aims to save some memory (6 bytes!) and simplify the code. We also lower CPU usage by sending the 50B message at 100ms instead of 10ms.
How
We use correct Nissan terminology (MPRUN for the counters), and use the same variable for all 10ms messages.