Refresh checksession iframe regularly #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @valdian Thanks for the PR. You will need to add some tests before we can merge. Can you help me a bit here, what does this PR fix or address? How can I reproduce the problem? I have tested the checkSession and this works for me (The way I test it, but I assume you use it different, so I probably missed something) Greetings and thanks for the PR Damien |
|
PR is good, would like to merge this and add it back in. @FabianGosebrink @valdian How will we solve the tests? |
FabianGosebrink
approved these changes
May 30, 2020
|
Thank you @valdian . Thanks for your contribution! Highly appreciated. |
|
@valdian thanks for this, we will test and release in the next few days. Version 11.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh check session iframe regularly (always after 60 seconds), like it used to work before commit 1750ee2.
Fixes #756.