Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the authority server goes down, the oidc.security.check-session se… #314

Merged
merged 3 commits into from
Oct 14, 2018

Conversation

profet23
Copy link
Contributor

…rvice will now emit an onCheckSessionChanged event.

The server will be checked every sixty seconds.
If a message isn't received from the check session iframe within 3 "beats" of the check session heart beat. An event will be emitted.

The iframe will only stop emitting events after the server is checked. So the event will be emitted at a minimum of 3 beats (9 seconds) and maximum of sixty seconds + 3 beats (69 seconds).

Fixes #310

Benjamin Grabkowitz added 2 commits October 11, 2018 13:54
…rvice will now emit an onCheckSessionChanged event.

The server will be checked every sixty seconds.
If a message isn't received from the check session iframe within 3 "beats" of the check session heart beat. An event will be emitted.

The iframe will only stop emitting events after the server is checked. So the event will be emitted at a minimum of 3 beats (9 seconds) and  maximum of sixty seconds + 3 beats (69 seconds).

Fixes damienbod#310
@damienbod damienbod merged commit 8fba4d9 into damienbod:master Oct 14, 2018
@damienbod
Copy link
Owner

@profet23 fix works great, thanks!

WIll release a new version today, version 7.0.0. @FabianGosebrink changes in the events is a breaking change, we still need some docs before I do the release.

Thanks

@patolax
Copy link

patolax commented Oct 14, 2018

hi,

Is this fix available, in which version of lib?

@profet23 profet23 deleted the Bug310 branch October 14, 2018 22:32
@profet23
Copy link
Contributor Author

It should be 7.0.0 @tpatikirikorala

@damienbod
Copy link
Owner

Yes, this has been released in version 7.0.0 yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants