Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added console debug to fulfill browser filters #1499

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Added console debug to fulfill browser filters #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/angular-auth-oidc-client/src/lib/logging/console-logger.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ export class ConsoleLoggerService implements AbstractLoggerService {
}

logDebug(message?: any, ...args: any[]): void {
console.log(message, ...args);
console.debug(message, ...args);
}
}
16 changes: 8 additions & 8 deletions projects/angular-auth-oidc-client/src/lib/logging/logger.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,56 +116,56 @@ describe('Logger Service', () => {

describe('logDebug', () => {
it('should not log if no log level is set (null)', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: null }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should not log if no log level is set (undefined)', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1' }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should not log if log level is turned off', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.None }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should log when loglevel is Debug and value is string', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Debug }, 'some message');
expect(spy).toHaveBeenCalledOnceWith('[DEBUG] configId1 - some message');
});

it('should log when loglevel is Debug and value is object', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Debug }, { some: 'message' });
expect(spy).toHaveBeenCalledOnceWith('[DEBUG] configId1 - {"some":"message"}');
});

it('should log when loglevel is Debug with args', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Debug }, 'some message', 'arg1', 'arg2');
expect(spy).toHaveBeenCalledOnceWith('[DEBUG] configId1 - some message', 'arg1', 'arg2');
});

it('should not log when loglevel is Warn', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Warn }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should not log when loglevel is error', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Error }, 'some message');
expect(spy).not.toHaveBeenCalled();
Expand Down