Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirectUrl customization (via AuthOptions) #1372

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

mduriancik
Copy link

I've tried to implement my feature request: Optimisation for popup login #1361.

The implementation is more generic (and also simpler) and enables to customize the redirect URL (via AuthOptions) for not only authorizeWithPopUp() but also for authorize().

related issue: #1361

@FabianGosebrink
Copy link
Collaborator

Good PR, thanks. Can you add this to the docs as well?

@mduriancik
Copy link
Author

mduriancik commented Feb 14, 2022

Hello Fabian, I've modified the code as you'd suggested and I've added documentation. Have you other remarks, suggestions?

@FabianGosebrink
Copy link
Collaborator

Thank you for this effort! Merge @damienbod ?

@damienbod damienbod merged commit 49a1f6a into damienbod:main Feb 15, 2022
@patrickstecker
Copy link

Great Feature! When do you plan to release it? I need this for following usecase:
A user sends a link to my app to another user, this user wants to open the link, but is not logged in. So he has to login first. But after login, he ist currently redirected to the standard redirectUrl, not to the link the other user send him.
I guess this PR might be the soloution for me.

@smallswan399
Copy link

Great Feature! When do you plan to release it? I need this for following usecase: A user sends a link to my app to another user, this user wants to open the link, but is not logged in. So he has to login first. But after login, he ist currently redirected to the standard redirectUrl, not to the link the other user send him. I guess this PR might be the soloution for me.

Did you find the solution @patrickstecker ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants