Bugfix: the "use" attr on the jwks key is optional if only one key is present #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreaslarssen Thanks for the PR, I'll review and merge to 11 is possible |
|
@damienbod thanks. Let me know if there's anything wrong with it, or if you have other inputs, and I'll fix as soon as possible. Also let me know your thoughts on my comment on the validation of no of keys |
|
thanks, released in version 11.6.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any contribution docs, and wasn't able to set this up locally, so I coded this "blindly". If someone could verify my changes, that would be great.
One remark: Is the check for multiple key candidates needed? Removing it would result in the client using whatever key was defined last, and either the verification will fail (wrong key), or it will be verified (right key, by chance). Would not uncover an error in the jwks endpoint, but is that really up to the client to uncover?
EDIT: Could this be released as a patch of version 11?