Skip to content

Commit

Permalink
Merge pull request #1499 from damienbod/fabiangosebrink/console-logs-…
Browse files Browse the repository at this point in the history
…are-not-considered-as-Debug-type-logs-1436

Added console debug to fulfill browser filters
  • Loading branch information
damienbod authored Aug 6, 2022
2 parents d0973ed + c0fc7eb commit 87167e8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ export class ConsoleLoggerService implements AbstractLoggerService {
}

logDebug(message?: any, ...args: any[]): void {
console.log(message, ...args);
console.debug(message, ...args);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -116,56 +116,56 @@ describe('Logger Service', () => {

describe('logDebug', () => {
it('should not log if no log level is set (null)', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: null }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should not log if no log level is set (undefined)', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1' }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should not log if log level is turned off', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.None }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should log when loglevel is Debug and value is string', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Debug }, 'some message');
expect(spy).toHaveBeenCalledOnceWith('[DEBUG] configId1 - some message');
});

it('should log when loglevel is Debug and value is object', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Debug }, { some: 'message' });
expect(spy).toHaveBeenCalledOnceWith('[DEBUG] configId1 - {"some":"message"}');
});

it('should log when loglevel is Debug with args', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Debug }, 'some message', 'arg1', 'arg2');
expect(spy).toHaveBeenCalledOnceWith('[DEBUG] configId1 - some message', 'arg1', 'arg2');
});

it('should not log when loglevel is Warn', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Warn }, 'some message');
expect(spy).not.toHaveBeenCalled();
});

it('should not log when loglevel is error', () => {
const spy = spyOn(console, 'log');
const spy = spyOn(console, 'debug');

loggerService.logDebug({ configId: 'configId1', logLevel: LogLevel.Error }, 'some message');
expect(spy).not.toHaveBeenCalled();
Expand Down

0 comments on commit 87167e8

Please sign in to comment.