Do not set the terminal to raw mode if it isn't actually a terminal #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
force-pushed
the
fix-xterm-nonterminal
branch
from
9dd8b69 to
5304bfe
Compare
aykevl
force-pushed
the
fix-xterm-nonterminal
branch
from
5304bfe to
1307875
Compare
|
@dalance can you take a look at this PR? |
|
@aykevl Sorry for the late reply. I missed this PR. |
It doesn't make sense to try to set a terminal as a raw terminal if it isn't actually a terminal. Worse, this may break tests that assume they can simply provide a pipe to a subprocess and expect the terminal will be unchanged. See this PR, which needs this patch: sharkdp/bat#2631
aykevl
force-pushed
the
fix-xterm-nonterminal
branch
from
1307875 to
cfbb47e
Compare
|
I've updated the PR! I've tested the PR with Rust 1.69, but according to the is-terminal crate it should work with Rust down to version 1.63. Also I ran |
|
Thanks! |
|
That was my first Rust PR :) I'll be using it in bat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to try to set a terminal as a raw terminal if it isn't actually a terminal. Worse, this may break tests that assume they can simply provide a pipe to a subprocess and expect the terminal will be unchanged.
See this PR, which needs this patch:
sharkdp/bat#2631
Note that this requires Rust 1.70 for the
IsTerminaltrait, if that's too new I can switch this PR to use the is-terminal crate instead.https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html#isterminal