Improvement: Don't emit control codes to STDOUT for non-colored output. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking API changes mean 0.12.3 is yanked. The change is spelling of Assetion -> Assertion
Minimal bump to get ValueEnum, intended for use with `--dump-filelist`. https://docs.rs/clap/latest/clap/trait.ValueEnum.html
- No: Default does not dump anything. Equivalent to false in previous behaviour. - Yaml: Dump in YAML format showing how incdirs and defines change as child filelists are processed. Equivalent to true in previous behaviour. - Files: Dump only the final list of files, one per line, unquoted. Intended to be suitable for shell processing. This is the main motivation for this branch (see dalance#224). - Incdirs: Dump only the final list of include directories, similar to Files. - Defines: Dump only the final list of defines to be set *before* any preprocessing, similar to Files.
- `printer.print()`, `printer.println()` don't use Color::Reset, but all other `printer.*()` functions behave as before. - Directly addresses dalance#226, and indirectly addresses dalance#224.
DaveMcEwan
added a commit
to DaveMcEwan/svlint
that referenced
this pull request
Feb 8, 2023
This highlights the bug in using the Debug trait, now fixed on this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authors of clap appear to have stopped releasing multiple versions per day for
v3.x!--dump-filelistfrom bool to ValueEnum.--dump-filelist=no, or just not usingthe flag (backwards compatible).
--dump-filelist=yaml.That's a breaking change to the flag.
The output is functionally equivalent (except for the removed control codes).
files,incdirs,definesgive new modes where output is intended to beprocessed by shell scripts (see Feature: Add some pre-configured and explained "rulesets" (TOML files) with wrapper scripts. #224).
One line per file/incdir/define, without control codes.
printer.write()so that it doesn't require a color, andprinter.print,printer.printlntoavoid control codes for reset/clearing the terminal.
--dump-filelist, but they can't check for control codes.