Bugfix: Correct keyword regex used by style_keyword_*.
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DaveMcEwan
commented
Dec 8, 2022
DaveMcEwan
commented
- Reported in Bug: Panic in style rules #211.
- New regex determined by looking at all the possibilities in sv-parser, instead of reading the LRM.
- Previous regex did not allow for characters $, ', B, X, or Z.
- I think only $ was causing a real issue, but keyword regex has been updated to include all characters to avoid confusing corner-cases later.
New regex determined by looking at all the possibilities in sv-parser, instead of reading the LRM. Previous regex did not allow for $, ', B, X, or Z.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.