create metadata field #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dcposch
reviewed
Feb 12, 2025
| @@ -61,6 +62,8 @@ export interface PayParams { | |||
| preferredChains?: number[]; | |||
| /** Preferred tokens. These appear first in the token list. */ | |||
| preferredTokens?: { chain: number; address: Address }[]; | |||
| /** Developer metadata. E.g. correlation ID. */ | |||
There was a problem hiding this comment.
Metadata associated with this payment. Use eg. to track correlated IDs.
dcposch
reviewed
Feb 12, 2025
| @@ -61,6 +62,8 @@ export interface PayParams { | |||
| preferredChains?: number[]; | |||
| /** Preferred tokens. These appear first in the token list. */ | |||
| preferredTokens?: { chain: number; address: Address }[]; | |||
| /** Developer metadata. E.g. correlation ID. */ | |||
| metadata?: DaimoPayUserMetadata; | |||
There was a problem hiding this comment.
confirming that we don't expose our previous metadata anywhere... fortunately, it looks like we don't
dcposch
reviewed
Feb 12, 2025
There was a problem hiding this comment.
userMetadata looks solid
- what's a possible use case for userMetadata other than storing a single external ID?
- good chance the extra flexibility is valuable
do we need a way for DaimoPayButton to generate a unique payment?
rn I think we have this in the API (say you pass myCartId as metadata + also as the Idempotency-Key = guarantees you get exactly one payment per cart id, and the webhook will tell you which cart was paid)
but as far as I can tell we don't have it when using DaimoPayButton directly
dcposch
reviewed
Feb 15, 2025
| @@ -399,6 +402,8 @@ export function usePaymentState({ | |||
| preferredTokens: payParams.preferredTokens, | |||
| }, | |||
| }, | |||
| externalId: payParams.externalId, | |||
| userMetadata: payParams.metadata, | |||
dcposch
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.