Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners file #51

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Add codeowners file #51

merged 1 commit into from
Oct 6, 2018

Conversation

nathanmsmith
Copy link
Contributor

yay code review!

@dustinnewman
Copy link

@nathunsmitty what is @dailybruin/internal-sites-editors? is that a github org?

@nathanmsmith
Copy link
Contributor Author

it's a GitHub team in the db org that is made up of you and me – I'd like you to at least be requested for review on all PRs in Internal Tools even if you aren't the one approving most of them. The reason why it's a team is so that when we have a new internal tools person next year, we can just add them to the team and leave it without having to change every codeowners file across all DB repos

@dustinnewman
Copy link

@nathunsmitty LGTM!

@hongee hongee merged commit a1a4c90 into master Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants