Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#861] test: add: integration test for logDir configuration #864

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Feb 25, 2025

Issue: #861

@yottahmd yottahmd marked this pull request as ready for review February 25, 2025 11:23
@yottahmd yottahmd merged commit 1f6a07f into main Feb 25, 2025
4 checks passed
@yottahmd yottahmd deleted the 861-logdir branch February 25, 2025 14:01
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.98%. Comparing base (be37a0b) to head (3805a77).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/context.go 40.00% 2 Missing and 1 partial ⚠️
internal/cmdutil/eval.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   56.02%   55.98%   -0.04%     
==========================================
  Files          75       75              
  Lines        8188     8195       +7     
==========================================
+ Hits         4587     4588       +1     
- Misses       3215     3220       +5     
- Partials      386      387       +1     
Files with missing lines Coverage Δ
internal/cmd/context.go 73.61% <40.00%> (-0.85%) ⬇️
internal/cmdutil/eval.go 56.22% <0.00%> (-0.79%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be37a0b...3805a77. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant