Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#827] executor/docker: Fix: command arguments are not evaluated #832

Merged
merged 11 commits into from
Feb 12, 2025

comment in

6623d9c
Select commit
Loading
Failed to load commit list.
Merged

[#827] executor/docker: Fix: command arguments are not evaluated #832

comment in
6623d9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 12, 2025 in 0s

55.73% (-0.20%) compared to 36d23aa

View this Pull Request on Codecov

55.73% (-0.20%) compared to 36d23aa

Details

Codecov Report

Attention: Patch coverage is 65.68323% with 221 lines in your changes missing coverage. Please review.

Project coverage is 55.73%. Comparing base (36d23aa) to head (6623d9c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/digraph/executor/command.go 0.00% 91 Missing ⚠️
internal/digraph/scheduler/node.go 70.63% 54 Missing and 20 partials ⚠️
internal/digraph/scheduler/data.go 83.40% 33 Missing and 4 partials ⚠️
internal/digraph/executor/docker.go 0.00% 11 Missing ⚠️
internal/digraph/scheduler/scheduler.go 88.13% 6 Missing and 1 partial ⚠️
internal/digraph/scheduler/graph.go 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   55.93%   55.73%   -0.20%     
==========================================
  Files          73       74       +1     
  Lines        7920     8108     +188     
==========================================
+ Hits         4430     4519      +89     
- Misses       3110     3202      +92     
- Partials      380      387       +7     
Files with missing lines Coverage Δ
internal/digraph/scheduler/graph.go 73.78% <87.50%> (ø)
internal/digraph/scheduler/scheduler.go 83.06% <88.13%> (-2.46%) ⬇️
internal/digraph/executor/docker.go 0.77% <0.00%> (-0.03%) ⬇️
internal/digraph/scheduler/data.go 83.40% <83.40%> (ø)
internal/digraph/scheduler/node.go 67.00% <70.63%> (-2.80%) ⬇️
internal/digraph/executor/command.go 2.32% <0.00%> (-1.90%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36d23aa...6623d9c. Read the comment docs.