Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Email attachment testcase (Fixes #812) #814

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

arky
Copy link
Contributor

@arky arky commented Feb 9, 2025

Surface email attachments feature in mail executor and update docs.

@arky arky requested a review from yottahmd February 9, 2025 12:50
@arky arky force-pushed the 812-email-attachments branch from d3b45cd to 99f9cd3 Compare February 10, 2025 12:00
@arky arky force-pushed the 812-email-attachments branch from 99f9cd3 to ec8c986 Compare February 10, 2025 12:18
@arky
Copy link
Contributor Author

arky commented Feb 10, 2025

@yohamta All lint tests now work correctly!

@yottahmd
Copy link
Collaborator

Looking good to me! Thanks for implementing the attachment functionality and updating the document!

@yottahmd yottahmd merged commit c831612 into dagu-org:main Feb 10, 2025
4 checks passed
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.93%. Comparing base (39f0ce8) to head (ec8c986).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   56.06%   55.93%   -0.14%     
==========================================
  Files          73       73              
  Lines        7921     7920       -1     
==========================================
- Hits         4441     4430      -11     
- Misses       3102     3110       +8     
- Partials      378      380       +2     
Files with missing lines Coverage Δ
internal/digraph/executor/mail.go 32.75% <ø> (ø)

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f0ce8...ec8c986. Read the comment docs.

@yottahmd yottahmd linked an issue Feb 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Attachment Support for Mail Executor
2 participants